build

systemaccounting · Dec 31, 2023 · 3512762 · 3512762
1 parent c0c4ebe
commit 3512762
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/.github/workflows/dev-crates.yaml b/.github/workflows/dev-crates.yaml
@@ -32,19 +32,21 @@ jobs:
         run: |
           make rust-coverage RUST_PKG=types
           echo "MIN_CODE_COV=$(yq .crates.types.min_code_cov project.yaml)" >> $GITHUB_ENV
+          echo "CURR_CODE_COV=$(make rust-coverage-percent RUST_PKG=types)" >> $GITHUB_ENV
       - name: fail crates/types coverage under ${{ env.MIN_CODE_COV }}%
         run: |
-          if [[ $(make rust-coverage-percent RUST_PKG=types) -lt ${{ env.MIN_CODE_COV }} ]]; then
-            echo 'coverage dropped below ${{ env.MIN_CODE_COV }}%'
+          if [[ ${{ env.CURR_CODE_COV }} -lt ${{ env.MIN_CODE_COV }} ]]; then
+            echo 'coverage dropped below ${{ env.MIN_CODE_COV }}: ${{ env.CURR_CODE_COV }}%'
             exit 1
           fi
       - name: crates/pg coverage report
         run: |
           make rust-coverage RUST_PKG=pg
           echo "MIN_CODE_COV=$(yq .crates.pg.min_code_cov project.yaml)" >> $GITHUB_ENV
+          echo "CURR_CODE_COV=$(make rust-coverage-percent RUST_PKG=pg)" >> $GITHUB_ENV
       - name: fail crates/pg coverage under ${{ env.MIN_CODE_COV }}%
         run: |
-          if [[ $(make rust-coverage-percent RUST_PKG=pg) -lt ${{ env.MIN_CODE_COV }} ]]; then
-            echo 'coverage dropped below ${{ env.MIN_CODE_COV }}%'
+          if [[ ${{ env.CURR_CODE_COV }} -lt ${{ env.MIN_CODE_COV }} ]]; then
+            echo 'coverage dropped below ${{ env.MIN_CODE_COV }}: ${{ env.CURR_CODE_COV }}%'
             exit 1
           fi
diff --git a/crates/pg/src/lib.rs b/crates/pg/src/lib.rs
@@ -505,10 +505,6 @@ mod tests {
         }
     }
 
-    // struct TestDB;
-
-    // impl DatabaseConnectionTrait for TestDB {}
-
     #[test]
     #[serial]
     fn from_account_profile_row_called_with_args() {