Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double unref issue when using signal callback #8

Closed
wants to merge 1 commit into from

Conversation

awarecan
Copy link

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@awarecan
Copy link
Author

CLA signed

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@awarecan
Copy link
Author

CI had failed on master...

@davide125
Copy link
Collaborator

CI failure is unrelated, it's failing in master as well -- the version of systemd we have in Travis is too old

@aleivag
Copy link
Collaborator

aleivag commented Jun 21, 2018

Hey Thanks for submitting code, we really apreciate when people take their time to collaborate. and yeap, i need to fix travis, because i would like to make test to verify that we dont break you.

Please also see my comment in issue #7 about how there is another solution for this...

thanks

@aleivag
Copy link
Collaborator

aleivag commented Dec 1, 2019

this was addressed already, and no further discussion has been make

@aleivag aleivag closed this Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use signals
4 participants