Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "agent(alt): temporarily disable -fsantize=function" #676

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "agent(alt): temporarily disable -fsantize=function" #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions agent/bootstrap-alt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,23 +207,17 @@ fi
# See:
# https://bugzilla.redhat.com/show_bug.cgi?id=1827338#c3
# https://github.com/systemd/systemd-centos-ci/issues/247

# FIXME (-fno-sanitize=function)
# systemd's hashmap implementation fails miserably with -fsanitize=function,
# so let's disable it until [0] is resolved.
#
# [0] https://github.com/systemd/systemd/issues/29972
(
export CC=clang
export CXX=clang++
# Make sure we copy over the meson logs even if the compilation fails
# shellcheck disable=SC2064
trap "[[ -d $BUILD_DIR/meson-logs ]] && cp -r $BUILD_DIR/meson-logs '$LOGDIR'" EXIT
meson "$BUILD_DIR" \
-Dc_args='-Og -fno-omit-frame-pointer -ftrapv -shared-libasan -fno-sanitize=function' \
-Dc_link_args="-shared-libasan -fno-sanitize=function" \
-Dcpp_args='-Og -fno-omit-frame-pointer -ftrapv -shared-libasan -fno-sanitize=function' \
-Dcpp_link_args="-shared-libasan -fno-sanitize=function" \
-Dc_args='-Og -fno-omit-frame-pointer -ftrapv -shared-libasan' \
-Dc_link_args="-shared-libasan" \
-Dcpp_args='-Og -fno-omit-frame-pointer -ftrapv -shared-libasan' \
-Dcpp_link_args="-shared-libasan" \
-Db_asneeded=false `# See the FIXME (--as-needed) above` \
-Ddebug=true \
--werror \
Expand Down