Added configuration option for setting mem_limit in /sys/block/zramX/… #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mem_limit, needed in cases when zram device size is big with compression ratios that can't be fit in RAM yet zram device does not report as being full. Option is "zram-resident-limit = " and syntax is same as with setting 'zram-size ='. Tested on my system and works as expected, additional test may be needed.
nabijaczleweli
requested changes
Feb 21, 2024
man/zram-generator.conf.md
Outdated
|
|
||
| Sets the maximum resident memory limit of the zram device as a function of *MemTotal*, available as the `ram` variable. | ||
|
|
||
| Arithmetic operators (^%/\*-+), e, π, SI suffixes, log(), int(), ceil(), floor(), round(), abs(), min(), max(), and trigonometric functions are supported. |
There was a problem hiding this comment.
"Same format as zram-size.", merge with next para at the end
man/zram-generator.conf.md
Outdated
|
|
||
| Arithmetic operators (^%/\*-+), e, π, SI suffixes, log(), int(), ceil(), floor(), round(), abs(), min(), max(), and trigonometric functions are supported. | ||
|
|
||
| Defaults to *0* meaning there is no limit, usefull to set when having zram device bigger than available RAM. |
There was a problem hiding this comment.
"Defaults to 0 (no limit)."
src/config.rs
Outdated
Comment on lines
130
to
147
| self.mem_limit = (match self.zram_resident_limit.as_ref() { | ||
| Some(zs) => { | ||
| zs.1.from(&zs.2.ps) | ||
| .eval(&zs.2, &mut RamNs(memtotal_mb as f64)) | ||
| .with_context(|| format!("{} zram-resident-limit", self.name)) | ||
| .and_then(|f| { | ||
| if f >= 0. { | ||
| Ok(f) | ||
| } else { | ||
| Err(anyhow!("{}: zram-resident-limit={} < 0", self.name, f)) | ||
| } | ||
| })? | ||
| } | ||
| None => 0.0, | ||
| } * 1024. | ||
| * 1024.) as u64; | ||
|
|
||
| Ok(()) |
There was a problem hiding this comment.
this clearly duplicates the else in set_disksize_if_enabled(); lift it out
Comment on lines
+366
to
+373
| let mut sl = fasteval::Slab::new(); | ||
| dev.zram_resident_limit = Some(( | ||
| value.to_string(), | ||
| fasteval::Parser::new() | ||
| .parse_noclear(value, &mut sl.ps) | ||
| .with_context(|| format!("{} zram-resident-limit", dev.name))?, | ||
| sl, | ||
| )); |
There was a problem hiding this comment.
clear copy-paste of the "zram-size" branch
zram-generator.conf.example
Outdated
| # zram-resident-limit=ram/8, then the resident space on RAM won't | ||
| # exceed 64MiB. Recomended value is ram / 2. | ||
| # | ||
| # The default is "0" |
zram-generator.conf.example
Outdated
| # The maximum size of resident memory of zram device, as function of | ||
| # MemTotal, both in MB. For example, if the machine has 1GiB, and | ||
| # zram-resident-limit=ram/8, then the resident space on RAM won't | ||
| # exceed 64MiB. Recomended value is ram / 2. |
zram-generator.conf.example
Outdated
Comment on lines
23
to
25
| # MemTotal, both in MB. For example, if the machine has 1GiB, and | ||
| # zram-resident-limit=ram/8, then the resident space on RAM won't | ||
| # exceed 64MiB. Recomended value is ram / 2. |
There was a problem hiding this comment.
math wrong I think?
zram-generator.conf.example
Outdated
| @@ -19,6 +19,14 @@ host-memory-limit = 9048 | |||
| # The default is "min(ram / 2, 4096)". | |||
| zram-size = min(ram / 10, 2048) | |||
|
|
|||
| # The maximum size of resident memory of zram device, as function of | |||
There was a problem hiding this comment.
"The maximum memory resident for this zram device, as a function of MemTotal, both in MB." Also format this like the sexion above :v
|
Pushed new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mem_limit, needed in cases when
zram device size is big with compression ratios that can't be fit in RAM yet zram device does not report as being full. Option is "zram-resident-limit = " and syntax is same as with setting 'zram-size ='. Tested on my system and works as expected, additional test may be needed.