This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Add file extension into the main field. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should contains the full name of the main script to avoid errors. Currently if loaded in npkg as https://unpkg.com/[email protected] It redirects to https://unpkg.com/[email protected]/json and results in `Cannot find "/json" in [email protected]` After the fix it should redirect to `https://unpkg.com/[email protected]/json.js` and load correctly.
|
This seems to be working on the unpkg side now? |
|
@guybedford Looking at their history, seems they fix it the day after the problem happened. Probably lot of other packages failed so they reverted the change. See this. But for example the issue still happening in jsdelivr So it still worth merging it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should contains the full name of the main script to avoid errors.
Currently if loaded in npkg as https://unpkg.com/[email protected]
It redirects to https://unpkg.com/[email protected]/json and results in
Cannot find "/json" in [email protected]After the fix it should redirect to
https://unpkg.com/[email protected]/json.jsand load correctly.