-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/firgrep becoming #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridetoruin
reviewed
Sep 6, 2024
ridetoruin
reviewed
Sep 6, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
reviewed
Sep 11, 2024
ridetoruin
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic piece. I have one quibble about development, and a couple of typos.
ridetoruin
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Author's Note
Checklist
Philosophical or literary contribution (docs). Leave unchecked for
code
contribution.IMPLIED CONSENT By opening this pull request and contributing
philosophical or literary content, I accept that my writing is submitted
under the
ATTRIBUTION-NONCOMMERCIAL-SHAREALIKE 4.0 INTERNATIONAL,
which:
attribution is given.
I understand that my writing may be modified, remixed, and built upon by
others within the
systemphil/sphil
or sPhil project, in accordancewith the license terms, indefinitely. See
legal code.
REQUIRED I have followed the
formatting guidelines
and verified there are no formatting bugs.
Try markdown preview here.
REQUIRED I have followed the
Chicago author-date style.
REQUIRED I have added or verified metadata title, description, and
contributors at the very top of the file followed by a
##
titleheading. Additionally, I have ensured
isArticle
is set totrue
.Example:
Further information
I have signed the document with my name/username under either as
Authors
,Editors
orContributors
.REQUIRED I have ensured that the
project's central bibliography
contains the necessary bibliographical details for the citations I have
used.
Optional My article is a stub or I want to actively encourage
contribution, I've added the Stub component to the bottom of my content
or where relevant:
If Docs contribution is unchecked: Code contribution
(Apache version 2 license)
All code apart of what is inside
src/pages/**
(excluding/contributing/**
,_app.mdx
,_document.tsx
,_meta.json
,acknowledgements.mdx
,index.mdx
,privacy.mdx
,team.mdx
,terms.mdx
)is subject to Apache version 2 license. Basically, anything outside of
content, literature, philosophy.