Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define setting data type correctly for "civioffice_renderers" setting #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Define setting data type correctly for "civioffice_renderers" setting #76

wants to merge 1 commit into from

Conversation

jensschuppe
Copy link
Contributor

The civioffice_renderers setting is an array, but its metadata defined it as String with a JSON-serialization, which is not correct for settings.

This seemed to have caused errors like

In DAO.php line 3388:
                                                                       
  strlen(): Argument #1 ($string) must be of type string, array given

when retrieving (any) settings.

systopia-reference: 26585

@jensschuppe jensschuppe requested a review from pbatroff December 20, 2024 11:48
@jensschuppe jensschuppe added bug Something isn't working status:needs review Code needs review and testing labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbatroff pbatroff Awaiting requested review from pbatroff

Assignees
No one assigned
Labels
bug Something isn't working status:needs review Code needs review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jensschuppe