Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetContract should also return IBAN #82

Open
wants to merge 3 commits into
base: 26206-add-more-recurring-payment-types
Choose a base branch
from

Conversation

jojowork
Copy link
Contributor

No description provided.

@jojowork jojowork changed the base branch from master to 26206-add-more-recurring-payment-types October 14, 2024 13:49
Copy link
Member

@bjendres bjendres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I haven't run the code, but I trust you have.

Also, see inline comments

Civi/Contract/ActionProvider/Action/GetContract.php Outdated Show resolved Hide resolved
Civi/Contract/ActionProvider/Action/GetContract.php Outdated Show resolved Hide resolved
@bjendres
Copy link
Member

Let me know if you have questions

@bjendres
Copy link
Member

Looks good, but please try if

  • it works (you probably have)
  • you can set an empty value to this field ('')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants