Fix remote getFields action #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
requested changes
Dec 13, 2024
* `RemoteActionInterface` was missing as implemented in `AbstractRemoteGetFieldsAction` so remote contact ID weren't resolved. * `AbstractRemoteGetFieldsAction` now extends `BasicGetFieldsAction` so the phpdoc type hint of `AbstractEntity::getFields()` is matched.
dontub
force-pushed
the
fix-remote-get-fields
branch
from
7b866d8 to
aba7be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteActionInterfacewas missing as implemented inAbstractRemoteGetFieldsActionso remote contact ID weren't resolved.AbstractRemoteGetFieldsActionnow extendsBasicGetFieldsActionso the phpdoc type hint ofAbstractEntity::getFields()is matched.systopia-reference: 27543