Merge pull request #57 from systopia/fix-phpstan-issues

Fix phpstan issues
systopia · Mar 27, 2024 · 996b814 · 996b814
2 parents fe0b52e + e9c3a85
commit 996b814
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 4 deletions.
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -25,7 +25,6 @@ parameters:
 		# Wrong phpdoc type hint in Drupal
 		- '/^Parameter #1 \$key of method Drupal\\Core\\Form\\FormStateInterface::hasTemporaryValue\(\) expects string, array<int\|string> given.$/'
 		- '#^Method Drupal\\Core\\Form\\FormBuilderInterface::getForm\(\) invoked with \d+ parameters, 1 required.$#'
-		- '/^Parameter #1 \$form \(array<int\|string, mixed>\) of method [^\s]+::(build|validate|submit)Form\(\) should be contravariant with parameter \$form \(array\) of method Drupal\\Core\\Form\\(FormInterface|FormBase)::(build|validate|submit)Form\(\)$/'
 		-
 			message: '#^Variable property access on mixed.$#'
 			paths:

diff --git a/src/Form/AbstractJsonFormsForm.php b/src/Form/AbstractJsonFormsForm.php
@@ -115,7 +115,6 @@ protected function buildJsonFormsForm(array $form,
     $form['#attributes']['class'][] = 'json-forms';
 
     if ($recalculateOnChange) {
-      // @phpstan-ignore-next-line
       $form['#attached']['library'][] = 'json_forms/submit';
     }
 

diff --git a/src/Form/Control/Callbacks/SelectCallbacks.php b/src/Form/Control/Callbacks/SelectCallbacks.php
@@ -72,12 +72,10 @@ private static function getValue(array &$element, $input, FormStateInterface $fo
       return $element['#default_value'] ?? NULL;
     }
 
-    // @phpstan-ignore-next-line
     if (array_key_exists('#empty_value', $element) && $input === (string) $element['#empty_value']) {
       return '' === $element['#empty_value'] ? NULL : $element['#empty_value'];
     }
 
-    // @phpstan-ignore-next-line
     foreach (array_keys($element['#options']) as $option) {
       if ($input === (string) $option) {
         return $option;