added new field internerBezeicher (internal_identifier) #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated localisation fixed wrong intendations, tool long lines (code sniffer warnings) added new json-schema field internerBezeichner to test data in unittests Fix after rebase
dontub
requested changes
Jan 22, 2025
| value="data.grunddaten.internerBezeichner" | ||
| e-ng-required="false"></editable-field> | ||
| </div> | ||
| ` |
There was a problem hiding this comment.
This seems not to be intended.
| value="data.grunddaten.internerBezeichner" | ||
| e-ng-required="false"></editable-field> | ||
| </div> | ||
| ` |
There was a problem hiding this comment.
This seems not to be intended.
| @@ -78,6 +78,7 @@ public function testValidation(): void { | |||
| $grunddaten = (object) [ | |||
| 'titel' => 'Test', | |||
| 'kurzbeschreibungDesInhalts' => 'foo bar', | |||
| 'internerBezeichner' => 'interne id', | |||
There was a problem hiding this comment.
Seeing this I think we have problems with the field mapping when used in report forms. The value would be mapped to the FundingClearingProcess entity which makes no sense. So this field either has to be read only in clearing forms or the value has to be mapped to the FundingApplicationProcess entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systopia-reference: 25581
Added new field internalIdentifier to:
Adjusted unit tests and updated localisation.