list the repos that use www.github.com on the users page

szabgab · Apr 7, 2024 · a9abeac · a9abeac
1 parent fdf34f7
commit a9abeac
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 5 deletions.
diff --git a/src/render.rs b/src/render.rs
@@ -298,6 +298,18 @@ pub fn generate_user_pages(
                         })
                         .collect::<Vec<_>>(),
                 );
+
+                problems.insert(
+                    "vcs_with_www",
+                    selected_crates
+                        .iter()
+                        .filter(|krate| {
+                            !krate.repository.is_empty()
+                                && krate.repository.starts_with("https://www.github.com")
+                        })
+                        .collect::<Vec<_>>(),
+                );
+
                 problems.insert(
                     "both_rustfm_and_dot_rustfmt",
                     selected_crates

diff --git a/templates/incl/list_crate_errors.html b/templates/incl/list_crate_errors.html
@@ -7,29 +7,43 @@
       </thead>
     <tbody>
 
+    {% if problems["vcs_with_www"].size > 0 %}
+        <h2 class="title">VCS URL <b>www.github.com</b> instead of <b>github.com</b></h2>
+
+        See <a href="/about-repository#www">explanation</a>.
+
+        {% for crate in problems["vcs_with_www"] %}
+        <tr>
+            <td><a href="/crates/{{crate.name}}">{{crate.name}}</a></td>
+            <td><a href="{{crate.repository}}"><span class="tag is-danger is-light">repo</span></a></td>
+        </tr>
+        {% endfor %}
+    {% endif %}
+
+
     {% if problems["vcs_with_http"].size > 0 %}
-        <h2 class="title"><span class="tag is-danger is-light">VCS URL starting with <b>http</b> instead of <b>https</b></span></h2>
+        <h2 class="title">VCS URL starting with <b>http</b> instead of <b>https</b></h2>
 
         See <a href="/about-repository#https">explanation</a>.
 
         {% for crate in problems["vcs_with_http"] %}
         <tr>
             <td><a href="/crates/{{crate.name}}">{{crate.name}}</a></td>
-            <td><a href="{{crate.repository}}">repo</a></td>
+            <td><a href="{{crate.repository}}"><span class="tag is-danger is-light">repo</span></a></td>
         </tr>
         {% endfor %}
     {% endif %}
 
 
     {% if problems["both_rustfm_and_dot_rustfmt"].size > 0 %}
-        <h2 class="title"><span class="tag is-danger is-light">Has both rustfmt.toml and .rustfmt.toml</span></h2>
+        <h2 class="title">Has both rustfmt.toml and .rustfmt.toml</h2>
 
         One of them is disregarded
 
         {% for crate in problems["both_rustfm_and_dot_rustfmt"] %}
         <tr>
             <td><a href="/crates/{{crate.name}}">{{crate.name}}</a></td>
-            <td><a href="{{crate.repository}}">repo</a></td>
+            <td><a href="{{crate.repository}}"><span class="tag is-danger is-light">repo</span></a></td>
         </tr>
         {% endfor %}
     {% endif %}

diff --git a/templates/user.html b/templates/user.html
@@ -15,7 +15,7 @@ <h1 class="title">{{title}}</h1>
 
     {% include 'templates/incl/list_crate_errors.html' %}
 
-    <h2 class="title is-5">Crates</h2>
+    <h2 class="title">Crates</h2>
     {% include 'templates/incl/list_crates.html' %}
 
   </div>