Update opensource.md #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added instructions for creating docker containers for the following projects: sanic-restful nbt-structure-utils penn toml_tools dialogy
szabgab
reviewed
Apr 28, 2023
| ``` | ||
| git clone [email protected]:skit-ai/dialogy.git | ||
| cd dialogy | ||
| docker run -it --name dialogy_test -w /opt -v <working directory>\dialogy:/opt python:3.11 bash |
There was a problem hiding this comment.
Instead of -v <working directory>\dialogy write -v $(pwd)
And if you'd like, you can add a further example for Windows as well.
szabgab
reviewed
Apr 28, 2023
| $ pip install poetry (opened a [PR](https://github.com/skit-ai/dialogy/pull/194)) for adding this command | ||
| $ poetry install | ||
| $ make test | ||
| ``` |
There was a problem hiding this comment.
So this was mostly already there, right?
szabgab
reviewed
Apr 28, 2023
|
That's right.
Added the installation command for poetry.
בתאריך יום ו׳, 28 באפר׳ 2023 ב-11:32 מאת Gábor Szabó <
***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In docker/opensource.md
<#22 (comment)>:
>
+```
+git clone ***@***.***:skit-ai/dialogy.git
+cd dialogy
+docker run -it --name dialogy_test -w /opt -v <working directory>\dialogy:/opt python:3.11 bash
+# Activate your virtualenv, you can also let poetry take care of it.
+$ pip install poetry (opened a [PR](skit-ai/dialogy#194)) for adding this command
+$ poetry install
+$ make test
+```
So this was mostly already there, right?
—
Reply to this email directly, view it on GitHub
<#22 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANGBDLN5MJ5A66KHMWHEDHDXDN6AHANCNFSM6AAAAAAXO4WIKQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I think your version will be used more commonly.
בתאריך יום ו׳, 28 באפר׳ 2023 ב-11:23 מאת Gábor Szabó <
***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In docker/opensource.md
<#22 (comment)>:
>
+```
+git clone ***@***.***:skit-ai/dialogy.git
+cd dialogy
+docker run -it --name dialogy_test -w /opt -v <working directory>\dialogy:/opt python:3.11 bash
Instead of -v <working directory>\dialogy write
-v $(pwd)
And if you'd like, you can add a further example for Windows as well.
—
Reply to this email directly, view it on GitHub
<#22 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANGBDLKE7DQ2IU55G2ZWJBTXDN5AXANCNFSM6AAAAAAXO4WIKQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions for creating docker containers for the following projects: sanic-restful
nbt-structure-utils
penn
toml_tools
dialogy