Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all errors Sync + Send #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nightkr
Copy link

@nightkr nightkr commented Feb 4, 2019

This is required by failure::from_boxed_compat. Sync is not strictly required (it can be wrapped in a mutex separately), but we might as well forward it if the underlying error provides it.

@nightkr
Copy link
Author

nightkr commented Feb 4, 2019

Huh, apparently this is backwards-incompatible, because Rust doesn't automatically downcast Box<Foo + Send + Sync> into Box<Foo>. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant