New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Rust edition 2018 + fix some clippy warnings #29

Open

sameer wants to merge 1 commit into szeged:master from sameer:2018

sameer commented Nov 1, 2019 •

edited

Loading

Migrated the code to edition to 2018. Changes include:

try!(abc) --> abc?
Box<X> --> Box<dyn X>
No need for extern crate
use something_from_crate::ABC --> use crate::something_from_crate::ABC
&String --> &str
Simplify some struct creations ABC { x: x} --> ABC { x}

Edit: I'm not sure if this necessitates a version bump, but this isn't actually changing any functionality


          Migrate to Rust edition 2018 + fix some clippy warnings

f98fd5e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet