Introduce conditionalTags #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. Do we work on this package because we want users partially use it? |
|
I was considering more 'controversial' rules that we might want to add (e.g., your suggestion in #197 or possibly enforcing DocBlocks for hooks). If we apply this approach to some rules, why not apply it to all rules? |
Using static analysis for "'code'" (scripts) written for WordPress is 100% controversial. |
|
What we three see okay for this package that must be used by all. |
@IanDelMar Have you seen what others come up with before this package? Tragedy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows rules to be disabled. Rules are enabled by default.