Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing classpath in file by default #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sigee
Copy link

@sigee sigee commented Jul 21, 2023

Implemented the following feature request: #237

@szpak
Copy link
Owner

szpak commented Jul 21, 2023

Have you run gw check funcTest locally and it passed?

@sigee sigee force-pushed the passing-classpath-in-file-by-default branch from 90beb63 to f88c004 Compare July 21, 2023 19:57
@sigee
Copy link
Author

sigee commented Jul 21, 2023

Not yet. I'll fix them on the weekend. :)

@sigee sigee force-pushed the passing-classpath-in-file-by-default branch from f88c004 to 8c7087a Compare July 21, 2023 20:49
@sigee
Copy link
Author

sigee commented Jul 26, 2023

@szpak I've fixed the broken test cases by setting the useClasspathFile as false in the tests (as it was before). And there is one test case when it is true.
Is it ok in this way or should I rewrite all the cases for the new behavior and flip the one exception to set useClasspathFile to false?

@szpak szpak added this to the 1.14.1 milestone Sep 1, 2023
@sigee sigee force-pushed the passing-classpath-in-file-by-default branch from 8c7087a to 3d1874e Compare March 7, 2024 17:07
@sigee sigee force-pushed the passing-classpath-in-file-by-default branch from 3d1874e to 3cef4bc Compare March 7, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants