Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a message in the console if a profile cannot be parsed #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

teone
Copy link

@teone teone commented Nov 20, 2020

cov.parseProfile returns errors if something goes wrong, but they are not checked.
This will print a message containing the error.

I was going for a log.Fatal in case of an error but that would change the behavior of the tool.

@coveralls
Copy link

coveralls commented Nov 20, 2020

Pull Request Test Coverage Report for Build 37

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 79.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gocover-cobertura.go 1 3 33.33%
Totals Coverage Status
Change from base Build 29: -0.6%
Covered Lines: 250
Relevant Lines: 316

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants