1. Log helpful error message on JSON parse failure, 2. Object value instead of String #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Anton,
Here is the PR as promised. It is only a small change. It helps when developing clients as you can see more easily when you are going wrong.
This change also has a
Map<String, Object>to hold the key value pairs instead ofMap<String, String>. That lets me send a numeric type to Graylog and have it end up in Elasticsearch as as numeric type.I saw that you already had a test for bad JSON, so I left that as it was. I'm actually not sure how to validate the presence of the new error message in the logs, but you can see it does get printed to the console when building.
Regards,
James