Packaged tacos have version in file name

[pvanderknyff]

Change the name of the packaged taco to include the version number. So our packaged Postgres JDBC sample would be:
postgres_jdbc-v0.0.0.taco

This will make it easier to see which taco is which version without having to inspect the archive. Many of our partners do this already manually.

Updated our xml parser tests to check that the version is correctly taken from the manifest. We don't have to worry about the case when the connector version is not set when we create the package name, as not having plugin-version is an XML violation and the connector will be rejected before then.

[pep8speaks]

Thanks for updating the PR.

• In the file connector-packager/connector_packager/xml_parser.py:

Line 42:38: E261 at least two spaces before inline comment

• In the file connector-packager/tests/test_xml_parser.py:

Line 96:121: E501 line too long (132 > 120 characters)
Line 71:121: E501 line too long (141 > 120 characters)
Line 53:121: E501 line too long (144 > 120 characters)
Line 51:1: W293 blank line contains whitespace
Line 48:121: E501 line too long (126 > 120 characters)
Line 43:121: E501 line too long (128 > 120 characters)
Line 38:121: E501 line too long (127 > 120 characters)
Line 25:121: E501 line too long (132 > 120 characters)

Comment last updated at 2023-10-27 19:45:38 UTC

[pvanderknyff]

Note: not merging this right now.

I haven't merged that one because right now, when two connectors in the same folder conflict, we chose the one that comes first alphabetically. If we tag on the version number on the end, that means that the oldest version will be loaded first in this scenario, since the taco-v1 comes alphabetically before taco-v2.

We have a story on the backlog to revise the loading logic to load the newest version of the connector we find, and we shouldn't add logic to put the version name into the packager until then.