Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing set default permissions for virtual connections #1535

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fixing set default permissions for virtual connections #1535

merged 2 commits into from
Dec 13, 2024

Conversation

TrimPeachu
Copy link
Contributor

Fixes #1525

@jorwoods
Copy link
Contributor

Can you also add a unit test to ensure that the attribute is set correctly and able to be read?

@TrimPeachu
Copy link
Contributor Author

@jorwoods tests added

jacalata
jacalata approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good afaict, although I'm not actually familiar with the feature.

@jacalata jacalata merged commit 9379c40 into tableau:development Dec 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacalata jacalata jacalata approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrimPeachu @jorwoods @jacalata