Adding support for thumbnail related options in workbook publish #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacalata
approved these changes
Dec 4, 2024
| if workbook_item.thumbnails_user_id is not None: | ||
| workbook_element.attrib["thumbnailsUserId"] = workbook_item.thumbnails_user_id | ||
|
|
||
| if workbook_item.thumbnails_group_id is not None: |
There was a problem hiding this comment.
only one of them should be set, so maybe make this an else if?
There was a problem hiding this comment.
sounds good, will change it to elif
samples/publish_workbook.py
Outdated
| parser.add_argument("--file", "-f", help="local filepath of the workbook to publish") | ||
| parser.add_argument("--as-job", "-a", help="Publishing asynchronously", action="store_true") | ||
| parser.add_argument("--skip-connection-check", "-c", help="Skip live connection check", action="store_true") | ||
| parser.add_argument("--project", help="Project within which to publish the datasource") |
There was a problem hiding this comment.
nit: datasource -> workbook
jacalata
approved these changes
Dec 4, 2024
renoyjohnm
deleted the
rjohn/feat_export_workbook_filters_publish_thumbnails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for thumbnail related options,
thumbnailsUserId&thumbnailsGroupIdin workbook publish