Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added README.md #6

Merged
merged 10 commits into from
Dec 10, 2024
Merged

Added README.md #6

merged 10 commits into from
Dec 10, 2024

Conversation

Shvandre
Copy link
Collaborator

@Shvandre Shvandre commented Dec 2, 2024

Closes #2

@Shvandre Shvandre requested a review from anton-trunov December 2, 2024 15:03
@Shvandre
Copy link
Collaborator Author

Shvandre commented Dec 2, 2024

Also Updated Misti package, to fix CI

anton-trunov
anton-trunov reviewed Dec 3, 2024
View reviewed changes
README.md Show resolved Hide resolved
anton-trunov
anton-trunov requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the readme should also explain

the goals and the architecture of the project

The architecture here means the structure of the project, what contracts and traits it consists of, how those contracts are supposed to interact, etc.

README.md Outdated Show resolved Hide resolved
@Shvandre Shvandre requested a review from anton-trunov December 3, 2024 10:13
anton-trunov
anton-trunov requested changes Dec 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Shvandre Shvandre requested a review from anton-trunov December 6, 2024 12:53
@anton-trunov anton-trunov self-assigned this Dec 6, 2024
novusnota
novusnota previously approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

anton-trunov
anton-trunov requested changes Dec 10, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@anton-trunov anton-trunov merged commit 617800d into main Dec 10, 2024
1 check passed
@anton-trunov anton-trunov deleted the 2 branch December 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@novusnota novusnota novusnota left review comments

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update README.md
3 participants
@Shvandre @anton-trunov @novusnota