feat(stdlib): add ecrecover() and normalizeECDSARecoveryId() functions
#2774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want tests for this? :) |
| @@ -180,6 +180,56 @@ sha256(someVariableElsewhere); // will try to resolve at compile-time, | |||
|
|
|||
| ::: | |||
|
|
|||
| ## normalizeECDSARecoveryId | |||
There was a problem hiding this comment.
Abbreviations in camelcase must be capitalized as regular words, i.e. normalizeEcdsaRecoveryId
| /// | ||
| /// Note: This function uses the TVM `ECRECOVER` instruction and therefore requires `v` to | ||
| /// be already normalized with [`normalizeECDSARecoveryId()`](#normalizeecdsarecoveryid). | ||
| asm fun ecrecover(hash: Int, v: Int, r: Int, s: Int): EcrecoverKey? { |
There was a problem hiding this comment.
We shouldn't name functions in standard library after assembly instructions. ECRECOVER is a misnomer, as we're not recovering elliptic cryptography with it.
There was a problem hiding this comment.
There's a builtin ecrecover() function in Solidity, and people know that ecrecover and reference it elsewhere.
But I agree that we might need to change the name since ECRECOVER on TON does a slightly different thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2733.
Checklist
docs/and made the build locally