fix: remove the destructuring fields quantity check in interpreter #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gusarich
changed the title
anton-trunov
requested changes
Oct 17, 2024
|
@Gusarich Let's finish this PR asap, please |
Gusarich
force-pushed
the
fix-destructuring
branch
2 times, most recently
from
ea99e54
to
4b9e402
Compare
novusnota
previously approved these changes
Oct 24, 2024
anton-trunov
requested changes
Oct 28, 2024
3 tasks
Co-authored-by: Anton Trunov <[email protected]>
Gusarich
force-pushed
the
fix-destructuring
branch
from
b4b7a3f
to
623413b
Compare
|
@anton-trunov have a look please! |
anton-trunov
requested changes
Nov 3, 2024
|
Looks good to me. Let's merge the current version and then make one more iteration for v1.6 with the generalized destructuring, so we can do nested destructs |
anton-trunov
approved these changes
Nov 3, 2024
github-actions bot
pushed a commit
to TownSquareXYZ/tact
that referenced
this pull request
Nov 7, 2024
* remove the destructuring fields quantity check in interpreter * feat(typechecker): check variables count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #968.
Checklist
[ ] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases