Re-enable autoPatchelfHook
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`autoPatchelf` will already run as a post-fixup due to `nativeBuildInputs = [ autoPatchelfHook ]`.
|
@RatCornu @HPRIOR @name-snrl Could you please check if this PR works for you? Thanks! |
|
Hi, these changes will not affect my case from #93. The main issue was related to the |
|
Merged, thanks! |
|
Could we get this backported to the stable branch? I think it's affected by this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #96 which broke many if not all binaries (see #103).
Many derivations rely on
mkGenericand useautoPatchelfHookas a native build input. SincedontAutoPatchelf = truewas added tomkGenericin #96,autoPatchelfHooknever ran again, breaking all dynamic binaries.This PR removes
dontAutoPatchelf = truefrommkGenericand also adds some missing build inputs. This way,autoPatchelfwill again run as a post-fixup and will also fail if it cannot resolve a dependency instead of silently succeeding.Closes #103.
Supersedes #104.