Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos, links, errors, warnings, safety #182

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix typos, links, errors, warnings, safety #182

wants to merge 7 commits into from

Conversation

pabs3
Copy link

@pabs3 pabs3 commented May 12, 2023

  • Fix typos
  • Update http URLs to https
  • Fix link to the Fedora pass-otp package
  • Do not fail when otptool is installed but oathtool is not installed
  • Use command -v instead of which for finding programs
  • Use bash arrays to separate arguments to oathtool and otptool
  • Send secrets to oathtool via stdin instead of command-line arguments

pabs3 added 7 commits May 12, 2023 14:49
@pabs3
Fix typos
7267bb8 
Suggested-by: codespell
@pabs3
Update http URLs to https
39b2e81 
Avoid modifying embedded code copies, they should be fixed upstream
and either removed from pass-otp or updated from upstream.
@pabs3
Fix link to the Fedora pass-otp package
c99a469
@pabs3
Do not fail when otptool is installed but oathtool is not installed
49e52ad 
Fixes: commit 0aadd4c
@pabs3
Use command -v instead of which for finding programs
1c71a34 
which is non-standard and prints warnings when programs are not installed,
but pass-otp already handles programs not being installed properly.

Still use which in the tests because it usefully prints the $PATH too.
@pabs3
Use bash arrays to separate arguments to oathtool and otptool
79aea92 
Also use long version of oathtool -b/--base32 option.
@pabs3
Send secrets to oathtool via stdin instead of command-line arguments
aca5320 
Check if the oathtool version supports this first and prefer
the safe oathtool version to the always unsafe otptool.

Fixes: tadfisher#167
@pabs3 pabs3 mentioned this pull request May 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pabs3