[javascript] Find and use emscripten cmake toolchain in CMakeLists.txt (JS 2/n) #4105
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/AEsugiErJrkAFvTjfBvQ7udAeeK5 [Deployment for 576bb92 canceled] |
|
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 576bb92 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f0b404a952140008e8147f 😎 Browse the preview: https://deploy-preview-4105--docsite-preview.netlify.app |
CMakeLists.txt
Outdated
| @@ -4,6 +4,17 @@ | |||
|
|
|||
| cmake_minimum_required(VERSION 3.12) | |||
|
|
|||
| if((DEFINED TI_EMSCRIPTENED) AND TI_EMSCRIPTENED) | |||
There was a problem hiding this comment.
Maybe use cmake's like option command?
There was a problem hiding this comment.
Hmm. I added the option in #4093 already.
There was a problem hiding this comment.
But since TaichiCore.cmake is included after the project(taichi) call, that option isn't declared here. I didn't wanna redeclare the option either.
There was a problem hiding this comment.
If that's the case that option should be moved here probably. Since it's really a platform option not a taichi feature option
There was a problem hiding this comment.
that makes sense. I'll move it here.
| @@ -4,6 +4,17 @@ | |||
|
|
|||
| cmake_minimum_required(VERSION 3.12) | |||
|
|
|||
| if((DEFINED TI_EMSCRIPTENED) AND TI_EMSCRIPTENED) | |||
| if(DEFINED ENV{EMSCRIPTEN_DIR}) | |||
There was a problem hiding this comment.
Maybe consider using CMake variables directly? (i.e. -DEMSCRIPTEN_DIR=...) instead of environment variables? Environment variables are quite easy to pollute.
There was a problem hiding this comment.
I like that idea, but on the other hand we use environment variables everywhere else (TAICHI_CMAKE_ARGS, LLVM_DIR,... ) so I'm not sure. @ailzhang wdyt?
There was a problem hiding this comment.
@AmesingFlank sorry for the late reply! IMHO cmake variables are preferred way and we'll try to unify all cmake args into a singleTAICHI_CMAKE_ARGS env ;)
|
Closing ancient PR |
Related issue = #3781
Assuming that the path to the emscripten is stored in the
EMSCRIPTEN_DIRenvironment variable, this PR finds the cmake toolchain files needed to build taichi with emscripten.