-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(raiko): run general tests on all targets #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it still needs dynamic block number to avoid misleading blob deprecation error.
One more thought is: maybe some fixed input tests is also needed to make a kind of set of regression cases, but it generally ask for a stable input structure. Put it in todo for now :)
Right, will add! Though one the potential issues here is that big blocks take too long to test with, currently it's a very small block...
Ideally I think we can just generate test blocks directly, though having some cached real blocks may also be useful and easy. |
SGX hw test env setup is done: smtmfft#2 Can be updated after this one get merged. |
# Conflicts: # .github/workflows/ci.yml # scripts/run.sh
Have to be a bit careful now with changed behavior: I made it so MOCK=1 enables SGX_DIRECT, and I currently set MOCK=1 in CI here: So for running on actual SGX, make sure MOCK != 1. |
Not the nicest way to do it but it gets the job done especially because we don't have a lot of tests yet. We should split up general tests and tests that should run on all provers somehow.
Also currently depends on external RPC data which is not great but once we can create test blocks we can switch to that.