Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error refactor #168

Merged
merged 42 commits into from
May 13, 2024
Merged

Error refactor #168

merged 42 commits into from
May 13, 2024

Conversation

petarvujovic98
Copy link
Contributor

Addresses #153 config issues and #154, #158 error displaying

@petarvujovic98 petarvujovic98 marked this pull request as ready for review May 8, 2024 11:43
smtmfft
smtmfft approved these changes May 9, 2024
View reviewed changes
host/src/raiko.rs Outdated Show resolved Hide resolved
host/src/request.rs Outdated Show resolved Hide resolved
@petarvujovic98
Copy link
Contributor Author

@Brechtpd @smtmfft I believe this is ready for merging, the changes in this PR don't change any code flow, but do throw errors that are handled by the API instead of panicking in the host. The CI changes are only impacting the maintainability of the CI code itself

@petarvujovic98 petarvujovic98 mentioned this pull request May 13, 2024
Merged
Brechtpd
Brechtpd approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made some tiny unimportant changes in e7af23c

@Brechtpd Brechtpd merged commit 5ede08c into main May 13, 2024
11 checks passed
@Brechtpd Brechtpd deleted the error-refactor branch May 13, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smtmfft smtmfft smtmfft approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petarvujovic98 @Brechtpd @smtmfft