feat(raiko): refine error return to avoid incorrect status. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
smtmfft
changed the title
petarvujovic98
suggested changes
Aug 21, 2024
Co-authored-by: Petar Vujović <[email protected]>
Co-authored-by: Petar Vujović <[email protected]>
Co-authored-by: Petar Vujović <[email protected]>
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Signed-off-by: smtmfft <[email protected]>
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
petarvujovic98
approved these changes
Aug 21, 2024
Brechtpd
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use error return instead of panic! to avoid unclean status which leads to endless WIP status back to client.
Probably need more refines with API CI test @petarvujovic98 .