fix(prover): do not retry when the status in receipt is not `types.Re…

…ceiptStatusSuccessful` (#675) Co-authored-by: David <[email protected]>
taikoxyz · Apr 1, 2024 · 5f91e0e · 5f91e0e
1 parent 16fe52a
commit 5f91e0e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/metrics/metrics.go b/internal/metrics/metrics.go
@@ -42,6 +42,7 @@ var (
 	ProverSubmissionErrorCounter     = metrics.NewRegisteredCounter("prover/proof/submission/error", nil)
 	ProverSgxProofGeneratedCounter   = metrics.NewRegisteredCounter("prover/proof/sgx/generated", nil)
 	ProverPseProofGeneratedCounter   = metrics.NewRegisteredCounter("prover/proof/pse/generated", nil)
+	ProverSubmissionRevertedCounter  = metrics.NewRegisteredCounter("prover/proof/submission/reverted", nil)
 
 	// Transaction sender
 	TxSenderSentCounter                = metrics.NewRegisteredCounter("sender/sent/txs", nil)

diff --git a/prover/proof_submitter/transaction/sender.go b/prover/proof_submitter/transaction/sender.go
@@ -2,7 +2,6 @@ package transaction
 
 import (
 	"context"
-	"fmt"
 	"math/big"
 	"strings"
 
@@ -61,7 +60,9 @@ func (s *Sender) Send(
 	}
 
 	if receipt.Status != types.ReceiptStatusSuccessful {
-		return fmt.Errorf("failed to submit proof: %s", receipt.TxHash)
+		log.Error("Failed to submit proof", "txHash", receipt.TxHash)
+		metrics.ProverSubmissionRevertedCounter.Inc(1)
+		return ErrUnretryableSubmission
 	}
 
 	log.Info(