Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

Commit

Permalink
improve: use errors.New to replace fmt.Errorf with no parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
ChengenH committed Apr 20, 2024
1 parent 348d745 commit ea1e455
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions driver/state/l1_current.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package state

import (
"context"
"fmt"
"errors"
"math/big"

"github.com/ethereum/go-ethereum/common"
Expand All @@ -29,7 +29,7 @@ func (s *State) SetL1Current(h *types.Header) {
// BlockProposed event with given blockID / blockHash.
func (s *State) ResetL1Current(ctx context.Context, blockID *big.Int) error {
if blockID == nil {
return fmt.Errorf("empty block ID")
return errors.New("empty block ID")
}

log.Info("Reset L1 current cursor", "blockID", blockID)
Expand Down
4 changes: 2 additions & 2 deletions pkg/rpc/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package rpc

import (
"context"
"fmt"
"errors"
"math/big"

"github.com/ethereum/go-ethereum/beacon/engine"
Expand All @@ -22,7 +22,7 @@ type EngineClient struct {
func NewJWTEngineClient(url, jwtSecret string) (*EngineClient, error) {
var jwt = StringToBytes32(jwtSecret)
if jwt == (common.Hash{}) || url == "" {
return nil, fmt.Errorf("url is empty or jwt secret is illegal")
return nil, errors.New("url is empty or jwt secret is illegal")
}
authClient, err := rpc.DialOptions(context.Background(), url, rpc.WithHTTPAuth(node.NewJWTAuth(jwt)))
if err != nil {
Expand Down
8 changes: 4 additions & 4 deletions pkg/rpc/methods.go
Original file line number Diff line number Diff line change
Expand Up @@ -638,31 +638,31 @@ func (c *Client) getSyncedL1SnippetFromAnchor(
common.Hash{},
0,
0,
fmt.Errorf("failed to parse l1BlockHash from anchor transaction calldata")
errors.New("failed to parse l1BlockHash from anchor transaction calldata")
}
l1StateRoot, ok = args["_l1StateRoot"].([32]byte)
if !ok {
return common.Hash{},
common.Hash{},
0,
0,
fmt.Errorf("failed to parse l1StateRoot from anchor transaction calldata")
errors.New("failed to parse l1StateRoot from anchor transaction calldata")
}
l1Height, ok = args["_l1BlockId"].(uint64)
if !ok {
return common.Hash{},
common.Hash{},
0,
0,
fmt.Errorf("failed to parse l1Height from anchor transaction calldata")
errors.New("failed to parse l1Height from anchor transaction calldata")
}
parentGasUsed, ok = args["_parentGasUsed"].(uint32)
if !ok {
return common.Hash{},
common.Hash{},
0,
0,
fmt.Errorf("failed to parse parentGasUsed from anchor transaction calldata")
errors.New("failed to parse parentGasUsed from anchor transaction calldata")
}

return l1BlockHash, l1StateRoot, l1Height, parentGasUsed, nil
Expand Down
2 changes: 1 addition & 1 deletion prover/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func NewConfigFromCliContext(c *cli.Context) (*Config, error) {

// If we are not running a guardian prover, a raiko host endpoint is required.
if !c.IsSet(flags.GuardianProver.Name) && !c.IsSet(flags.RaikoHostEndpoint.Name) {
return nil, fmt.Errorf("raiko host not provided")
return nil, errors.New("raiko host not provided")
}

var (
Expand Down

0 comments on commit ea1e455

Please sign in to comment.