This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(prover): generate an oracle proof if incoming proof is incorrect #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if parentGasUsed and parentHash are correct, but blockHash is incorrect, generate an oracle proof and skip the current
proofWindowExpired
check.also include 3 general fixes:
we were not checking blockHash before when checking isValidProof before cancelling proof generation even for regular provers, so fixed that.
we should remove the block from
p.currentBlocksWaitingForProofWindow
in prover regardless of what happens after the proof window expires, right now it was only in one conditional block, which would lead to the map growing very large unnecessarily and checking too many blocks. we should also compare block hash here.was passing in l2BlockId instead of l1Height to
p.proveNotify
when checking expired windows