Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(all): changes based on contestable zkRollup protocol design #414

Merged
merged 66 commits into from
Oct 16, 2023

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Sep 28, 2023

  • changes based on new protocol design: feat(protocol): Based Contestable Rollup with multi-proofs and multi-hop bridging taiko-mono#14705
  • more comments & unit tests
  • decouple some components in prover
  • rename some flags
  • new prover flag --mode.contester
  • refactor the current proving window expiration check implementation, since different proof tiers will have a different proving window
  • refactor the current capacity manager by introducing a new slot manager (the idea is still the same as tempCapacity)
  • for the next testnet, we will require all provers to have the ability to generate both zk / SGX proofs (confirmed)

TODO:

  • add more tests
  • implement SGX proofProducer when our SGX implementation and verification contract are ready
  • if the current zk proof can not be generated by zkevm-circuits (maybe because there are too many transactions / some transactions have some accessLists / some transactions are legacy transactions / ...), our guardian prover should send keccak256("RETURN_LIVENESS_BOND") as proof.
  • host a swagger doc page (for prover server APIs) through github page
  • only manage capacity for zkevm proofs

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #414 (0801636) into main (4a1012a) will increase coverage by 3.85%.
The diff coverage is 53.02%.

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   50.08%   53.94%   +3.85%     
==========================================
  Files          39       44       +5     
  Lines        5043     5070      +27     
==========================================
+ Hits         2526     2735     +209     
+ Misses       2261     2061     -200     
- Partials      256      274      +18     
Files Coverage Δ
bindings/encoding/struct.go 96.34% <ø> (ø)
driver/chain_syncer/calldata/syncer.go 69.18% <100.00%> (+0.72%) ⬆️
driver/config.go 100.00% <100.00%> (ø)
proposer/config.go 96.42% <100.00%> (+3.02%) ⬆️
prover/anchor_tx_validator/anchor_tx_validator.go 58.82% <ø> (+3.26%) ⬆️
prover/config.go 92.10% <100.00%> (+3.50%) ⬆️
prover/proof_producer/dummy_producer.go 100.00% <100.00%> (ø)
prover/proof_producer/proof_producer.go 0.00% <ø> (ø)
prover/server/server.go 100.00% <100.00%> (+42.85%) ⬆️
prover/proof_producer/optimistic_producer.go 87.50% <87.50%> (ø)
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha marked this pull request as ready for review October 12, 2023 07:16
cmd/flags/driver.go Outdated Show resolved Hide resolved
cmd/flags/proposer.go Outdated Show resolved Hide resolved
prover/proof_submitter/proof_contester.go Outdated Show resolved Hide resolved
prover/proof_submitter/transaction/sender.go Outdated Show resolved Hide resolved
prover/proof_submitter/transaction/sender.go Outdated Show resolved Hide resolved
prover/proof_submitter/transaction/sender.go Outdated Show resolved Hide resolved
prover/proof_submitter/transaction/builder.go Outdated Show resolved Hide resolved
prover/proof_submitter/transaction/sender.go Outdated Show resolved Hide resolved
@davidtaikocha
Copy link
Member Author

davidtaikocha commented Oct 13, 2023

@cyberhorsey pushed a new commit for changes based on the feedbacks, ready for review again: 01b7d37

cmd/flags/common.go Outdated Show resolved Hide resolved
driver/state/state.go Outdated Show resolved Hide resolved
@davidtaikocha davidtaikocha merged commit 25a0c3b into main Oct 16, 2023
4 checks passed
@davidtaikocha davidtaikocha deleted the contestable-zkrollup branch October 16, 2023 05:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants