This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(prover): more accurate provingWindowExpiresAt calculation && update bindings
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
changed the title
provingWindowExpiresAt calculationprovingWindowExpiresAt calculation && update bindings
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 53.76% 53.76%
=======================================
Files 44 44
Lines 5093 5093
=======================================
Hits 2738 2738
Misses 2079 2079
Partials 276 276
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RogerLamTd
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentL1OriginHeaderis fromcurrentL1OriginHeader, err := p.rpc.L1.HeaderByNumber(ctx, new(big.Int).SetUint64(event.Meta.L1Height)), and in TaikoL1 contract,event.Meta.L1Heightisuint64(block.number - 1)