Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

ci: fix swag ci failure caused by typo annotation #454

Closed
wants to merge 2 commits into from
Closed

ci: fix swag ci failure caused by typo annotation #454

wants to merge 2 commits into from

Conversation

fenghaojiang
Copy link

@fenghaojiang fenghaojiang commented Nov 30, 2023

ci: fix swag ci failure caused by typo annotation

Previous version:

type SignedBlock struct {
	BlockID   uint64         `json:"blockID"`
	BlockHash string         `json:"blockHash"`
	Signature string         `json:"signature"`
	Prover    common.Address `json:"proverAddress"`
}

// GetSignedBlocks handles a query to retrieve the most recent signed blocks from the database.
//
//	@Summary		Get signed blocks
//	@ID			   	get-signed-blocks
//	@Accept			json
//	@Produce		json
//	@Success		200	{object} []SignedBlocks
//	@Router			/signedBlocks [get]

SignedBlocks -> SignedBlock.
SignedBlocks structure can not be detected as object so the ci failed like this:

2023/11/30 08:10:10 ParseComment error in file /home/runner/work/taiko-client/taiko-client/prover/server/api.go :cannot find type definition: SignedBlocks

@davidtaikocha
Copy link
Member

Closed by #455, thanks for the contribution anyway!

@RogerLamTd
Copy link
Contributor

RogerLamTd commented Dec 1, 2023

@gitpoap-bot please give @fenghaojiang a poap :) (not sure if this'll work)

@fenghaojiang
Copy link
Author

@gitpoap-bot please give @fenghaojiang a poap :) (not sure if this'll work)

Looks like do not work but it's ok. I am looking for other opportunities to contribute to taiko.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants