This repository has been archived by the owner on May 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 332
fix(prover): Reorder guardian prover sign + add allowance flag/logic #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
+ Coverage 60.62% 60.65% +0.02%
==========================================
Files 45 45
Lines 5341 5421 +80
==========================================
+ Hits 3238 3288 +50
- Misses 1780 1802 +22
- Partials 323 331 +8 ☔ View full report in Codecov by Sentry. |
cyberhorsey
changed the title
fix(prover): Reorder guardian prover sign
fix(prover): Reorder guardian prover sign + add allowance flag/logic
Dec 1, 2023
davidtaikocha
approved these changes
Dec 1, 2023
davidtaikocha
added a commit
that referenced
this pull request
Dec 1, 2023
davidtaikocha
added a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure L1 origin is synced for block ID before trying to sign the block hash, and add logs.
this also adds an
allowance
flag for the prover, which should both mitigate a LOT of devrel related help (as every day many people ask for "how do i set allowance" and "how much should i set", so we can set a sane default in the docker scripts), and let us have easier internal deployments so we dont have to approve every internal l1prover manually.