Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

fix(prover): Guardian prover sign wait #461

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Dec 2, 2023

wait for chain head to have block before trying to sign. THis is perhaps a temporary fix as there should be a secondary mechanism for guardian prover signing blocks, perhaps with its own blockProposedCh and own iterators, that way it doesnt exist alongside proving code.

I will do a further PR for a GuardianProverSigner struct that embeds in the Prover, and has its own event loop, after the weekend, if we want to go that route.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (d632109) 60.67% compared to head (94f7e5a) 60.53%.

Files Patch % Lines
prover/prover.go 35.48% 15 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   60.67%   60.53%   -0.14%     
==========================================
  Files          45       45              
  Lines        5416     5440      +24     
==========================================
+ Hits         3286     3293       +7     
- Misses       1800     1813      +13     
- Partials      330      334       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidtaikocha davidtaikocha merged commit 51fd8f9 into main Dec 2, 2023
5 checks passed
@davidtaikocha davidtaikocha deleted the guardian_prover_sign_wait branch December 2, 2023 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants