Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

chore(pkg): replace fmt.Errorf() with errors.New() if no param required #759

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

bodhi-crypo
Copy link
Contributor

similar to:ethereum/go-ethereum#27329

string formatting takes time (even if there's nothing to format), and also that the errors.New is optimized away.

@bodhi-crypo bodhi-crypo changed the title pkg,prover:replace fmt.Errorf() with errors.New() if no param required chore(pkg,prover):replace fmt.Errorf() with errors.New() if no param required Apr 24, 2024
@davidtaikocha davidtaikocha changed the title chore(pkg,prover):replace fmt.Errorf() with errors.New() if no param required chore(pkg): replace fmt.Errorf() with errors.New() if no param required Apr 24, 2024
@davidtaikocha davidtaikocha enabled auto-merge (squash) April 24, 2024 13:25
@davidtaikocha davidtaikocha merged commit 693be48 into taikoxyz:main Apr 24, 2024
4 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants