Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

fix: error handling improvements #773

Merged
merged 2 commits into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/rpc/blob_datasource.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,7 @@ func (ds *BlobDataSource) GetBlobs(
}
}
}
err = nil
return sidecars, err
return sidecars, nil
}

// getBlobFromServer get blob data from server path `/getBlob`.
Expand Down
2 changes: 1 addition & 1 deletion pkg/rpc/subscription.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,6 @@ func waitSubErr(ctx context.Context, sub event.Subscription) (event.Subscription
case err := <-sub.Err():
return sub, err
case <-ctx.Done():
return sub, nil
return sub, ctx.Err()
}
}
Loading