Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(prover_observability): Improve visibility to track prover's performance. #14894

Closed
00x-dx opened this issue Oct 3, 2023 · 2 comments
Closed

chore(prover_observability): Improve visibility to track prover's performance. #14894

00x-dx opened this issue Oct 3, 2023 · 2 comments
Labels
category.enhancement

Comments

@00x-dx
Copy link

00x-dx commented Oct 3, 2023 •
edited
Loading

Describe the feature request

This change would add the following metrics to improve the prover's visibility.

  • ProverProofGenerationTime - Track the proof generation time at p50, p75, p90 etc (in ns).

  • ProverValidProofSubmissionAcceptedCounter - Track the count of valid proof's resulting in successful acceptance.

  • ProverValidProofSubmissionErrorCounter - Track the count of valid proof's encountered in submission errors.

Describe alternatives you've considered

Logs

Additional context

NA
@00x-dx 00x-dx mentioned this issue Oct 3, 2023
Closed
@00x-dx 00x-dx changed the title chore(prover): Add valid proof submission error metric. chore(prover_observability): Improve visibility to track prover's performance. Oct 9, 2023
@00x-dx 00x-dx mentioned this issue Oct 9, 2023
Closed
@00x-dx
Copy link
Author

00x-dx commented Oct 9, 2023

PR.

@davidtaikocha
Copy link
Member

Closed by taikoxyz/taiko-client#426

@github-project-automation github-project-automation bot moved this from 📝 Todo to ✅ Done in Taiko Project Board Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category.enhancement
Projects
Taiko Project Board
Status: ✅ Done
Milestone
No milestone
2 participants
@davidtaikocha @00x-dx