Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

chore(prover): Add Valid Proof Submission Error metric #420

Closed
wants to merge 2 commits into from

Conversation

00x-dx
Copy link

@00x-dx 00x-dx commented Oct 3, 2023

It would fix 14894

@00x-dx 00x-dx changed the title chore(prover): Valid Proof submission error metric chore(prover): Add Valid proof submission error metric Oct 3, 2023
@00x-dx 00x-dx changed the title chore(prover): Add Valid proof submission error metric chore(prover): Add valid proof submission error metric Oct 3, 2023
@00x-dx 00x-dx changed the title chore(prover): Add valid proof submission error metric chore(prover): Add Valid Proof Submission error metric Oct 3, 2023
@00x-dx 00x-dx changed the title chore(prover): Add Valid Proof Submission error metric [Draft] chore(prover): Add Valid Proof Submission error metric Oct 3, 2023
@00x-dx 00x-dx changed the title [Draft] chore(prover): Add Valid Proof Submission error metric chore(prover): Add Valid Proof Submission error metric Oct 3, 2023
@00x-dx 00x-dx changed the title chore(prover): Add Valid Proof Submission error metric chore(prover): Add Valid Proof Submission Error metric Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #420 (6a796f9) into main (ff8c6b2) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   50.11%   50.12%           
=======================================
  Files          39       39           
  Lines        5040     5041    +1     
=======================================
+ Hits         2526     2527    +1     
  Misses       2258     2258           
  Partials      256      256           
Files Coverage Δ
prover/proof_submitter/util.go 41.52% <100.00%> (+0.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@00x-dx
Copy link
Author

00x-dx commented Oct 9, 2023

Let me club this together with other metrics.

@00x-dx 00x-dx closed this Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(prover_observability): Improve visibility to track prover's performance.
1 participant