Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guardian-prover-health-check): add Startups, new routes for getting recent signed block #15561

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Jan 24, 2024

The guardian prover dashboard should display the latest version and revision the specific guardian prover is on, as well as a history of their restarts and what those revisions/versions were, and their timestamps. This PR introduces that functionality for the API and exposes those endpoints to consume, as well as a post route for the taiko-client to save their startups.

It also adds a Get most recent signed block endpoint for a specific guardian prover, and test coverage.

There is a corresponding taiko-client PR to send the startups here: taikoxyz/taiko-client#529

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Jan 24, 2024 11:38pm

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (0e24d2d) 27.15% compared to head (0cc5f3f) 27.47%.

Files Patch % Lines
.../guardian-prover-health-check/http/post_startup.go 0.00% 38 Missing ⚠️
.../guardian-prover-health-check/repo/signed_block.go 0.00% 15 Missing ⚠️
...kages/guardian-prover-health-check/repo/startup.go 70.00% 11 Missing and 1 partial ⚠️
...h-check/http/get_startups_by_guardian_prover_id.go 35.71% 6 Missing and 3 partials ⚠️
...p/get_most_recent_startup_by_guardian_prover_id.go 57.14% 4 Missing and 2 partials ⚠️
...prover-health-check/healthchecker/healthchecker.go 0.00% 5 Missing ⚠️
..._most_recent_signed_block_by_guardian_prover_id.go 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           alpha-6   #15561      +/-   ##
===========================================
+ Coverage    27.15%   27.47%   +0.32%     
===========================================
  Files           94       99       +5     
  Lines         5700     5848     +148     
===========================================
+ Hits          1548     1607      +59     
- Misses        3988     4070      +82     
- Partials       164      171       +7     
Flag Coverage Δ *Carryforward flag
eventindexer 17.28% <ø> (ø) Carriedforward from 0e24d2d
guardian-prover-health-check 35.94% <39.86%> (+1.09%) ⬆️
relayer 40.61% <ø> (ø) Carriedforward from 0e24d2d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantaik dantaik added this pull request to the merge queue Jan 25, 2024
Merged via the queue into alpha-6 with commit 6d4cfe5 Jan 25, 2024
16 checks passed
@dantaik dantaik deleted the guardian_prover_new_endpoints branch January 25, 2024 03:06
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants