fix(taiko-client): some p2p fixes #18957
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mempirate
force-pushed
the
fix/driver-p2p
branch
from
6b4f445 to
b58bbcf
Compare
davidtaikocha
approved these changes
Feb 18, 2025
YoGhurt111
approved these changes
Feb 19, 2025
|
These changes should have been included in: #18944 , thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with flag parsing,
p2p.disablehas to be explicitly 1. set and 2. set tofalsein order for P2P to be initialized, but for some reason this resulted in other flags not being parsed correctly. Just checks the bool value now instead.