align derived traits of wrapper types with those of the underlying types #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change derives the following traits for the wrapper types, given that the underlying types also do the same. `Duration` - `Default` - `PartialOrd` - `Ord` `Timestamp` - `Copy` - `Hash` - `PartialOrd` - `Ord`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change derives the following traits for the wrapper types, given that the underlying types also do the same.
DurationDefaultPartialOrdOrdTimestampCopyHashPartialOrdOrdMinor version incremented in
Cargo.toml:If I understand Traits correctly, this should be backwards-compatible, since no dependent crate would be able to provide a conflicting implementation where both the trait and the type are foreign. If this understanding is incorrect, then this should be a major version bump, not a minor one (assuming Semantic Versioning, which seemed like a reasonable guess, since I didn't see an explicit indication of versioning policy).