Replace deprecated Nix vendorSha256 call with vendorHash #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget |
Signed-off-by: Patka <[email protected]>
Oops, that is now also done. |
|
Thanks @patka-123! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including the flake into my nixos system and doing a rebuild I get the following error:
The
vendorHashfunction is a drop in replacement, so with this PR the warning will be gone.(The deprecation of
vendorSha256can be verified by checking the nixos 23.11 release notes that say "The argument vendorSha256 of buildGoModule is deprecated. Use vendorHash instead. Refer to PR #259999 for more details.")