Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailscale,v2: remove ACLDERPNode.InsecureForTests #129

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

oxtoacart
Copy link
Contributor

@oxtoacart oxtoacart commented Dec 5, 2024

This is not an officially supported configuration option, and did not work anyway because the JSON name was misspelled.

Updates tailscale/tailscale#11776

STUNPort int `json:"stunPort,omitempty" hujson:"STUNPort,omitempty"`
STUNOnly bool `json:"stunOnly,omitempty" hujson:"STUNOnly,omitempty"`
DERPPort int `json:"derpPort,omitempty" hujson:"DERPPort,omitempty"`
STUNTestIP string `json:"stunTestIP,omitempty" hujson:"STUNTestIP,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this one too

… type

These are not officially supported configuration options. Also, InsecureForTests
did not work anyway because the JSON name was misspelled.

Updates tailscale/tailscale#11776

Signed-off-by: Percy Wegmann <[email protected]>
@oxtoacart oxtoacart merged commit 3c653bd into main Dec 5, 2024
3 checks passed
@oxtoacart oxtoacart deleted the percy/issue11776-1 branch December 5, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants