-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Contribution Guidelines #1087
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traxmaxx
requested review from
greghub,
mlabouardy,
victorgaard,
ShubhamPalriwala,
Kolawole99 and
AvineshTripathi
October 12, 2023 12:15
jakepage91
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just these three comments. Everything thing else looks super great and clean!
Kolawole99
suggested changes
Oct 12, 2023
mlabouardy
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Improve the contribution guidelines with missing informations for frontend development onboarding. Also add links to internal document references and cross-reference the QUickstart Guide for adding a
config.toml
Solution
Instruvtions are missing some key steps which is referecnes externally. This PR add the missing steps and cross-reference external documentation for things like setting up the
config.toml
Changes Made
/dashboard
for frontend specific thigns (TBD)How to Test
Read the
.md
files and make sure they parse fine. That's it.Screenshots
None needed. Use GitHub Markdown preview
Notes
Checklist
Reviewers
@[username of the reviewer]