-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animate default edges in resources explorer #1142
base: develop
Are you sure you want to change the base?
Animate default edges in resources explorer #1142
Conversation
hey @jolo-dev |
@Traxmaxx Yes, the animation is configurable. You can increase the Yeah, there is an interesting thing when changing pages or using components... Could that be a react thing where we have to use sort of a hook? Performance-wise, I did not notice anything. Maybe my dataset was too small.. |
Performance is a bit cumbersome to test atm. Will see if I can find a way in the future to make it easier. |
Let me investigate a bit. It's really weird... |
@jolo-dev thank you! I hope I can make up some time soon to also help out. I'll keep you posted! We will figure this out, sooner or later 😅 |
@Traxmaxx I am not a big React dev nor a fan :D |
The reason why this happens is because the function |
@jolo-dev I'll take a look when I have some time. Thanks for reporting your findings! |
Hey there @Traxmaxx were you able to look into this further? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but yeah, let's make the live edge movement slightly slower.
Not yet since I was doing the audit pages. How fast do you need input? : ) |
Problem
#1071
Solution
The edges are now animated.
Changes Made
How to Test
[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]
Screenshots
Screen.Recording.2023-10-27.at.16.27.10.mp4
Notes
Checklist
Reviewers
@[username of the reviewer]